undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Git.pm: better error message

Browse Source 
Provide the bad directory name alongside with $!

Note: $! is set if there is "No such file or directory",
but isn't set if the file exists but is not a directory.

Signed-off-by: Philippe Bruhat (BooK) <book@cpan.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Philippe Bruhat (BooK) 2010-06-18 01:47:31 +02:00 committed by Junio C Hamano
parent 74e42ce122
commit 64abcc4844
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
perl/Git.pm
View File

@ -172,7 +172,7 @@ sub repository {
} }
if (defined $opts{Directory}) { if (defined $opts{Directory}) {
-d $opts{Directory} or throw Error::Simple("Directory not found: $!"); -d $opts{Directory} or throw Error::Simple("Directory not found: $opts{Directory} $!");
my $search = Git->repository(WorkingCopy => $opts{Directory}); my $search = Git->repository(WorkingCopy => $opts{Directory});
my $dir; my $dir;
@ -545,7 +545,7 @@ sub wc_chdir {
or throw Error::Simple("bare repository"); or throw Error::Simple("bare repository");
-d $self->wc_path().'/'.$subdir -d $self->wc_path().'/'.$subdir
or throw Error::Simple("subdir not found: $!"); or throw Error::Simple("subdir not found: $subdir $!");
# Of course we will not "hold" the subdirectory so anyone # Of course we will not "hold" the subdirectory so anyone
# can delete it now and we will never know. But at least we tried. # can delete it now and we will never know. But at least we tried.