undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refs: fix find_containing_dir() regression

Browse Source 
The function used to return NULL when asked to find the containing
directory for a ref that does not exist, allowing the caller to
omit iteration altogether. But a misconversion in an earlier change
"refs.c: extract function search_for_subdir()" started returning the
top-level directory entry, forcing callers to walk everything.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2012-05-03 15:12:54 -07:00
parent 28e6a34e25
commit 663c1295d8
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
refs.c
View File

@ -390,8 +390,10 @@ static struct ref_dir *find_containing_dir(struct ref_dir *dir,
refname + dirname.len, refname + dirname.len,
(slash + 1) - (refname + dirname.len)); (slash + 1) - (refname + dirname.len));
subdir = search_for_subdir(dir, dirname.buf, mkdir); subdir = search_for_subdir(dir, dirname.buf, mkdir);
if (!subdir) if (!subdir) {
dir = NULL;
break; break;
}
dir = subdir; dir = subdir;
} }