sha1-file: close fd of empty file in map_sha1_file_1()
map_sha1_file_1() checks if the file it is about to mmap() is empty and errors out in that case and explains the situation in an error message. It leaks the private handle to that empty file, though. Have the function clean up after itself and close the file descriptor before exiting early. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
0d0ac3826a
commit
6881925ef5
@ -971,6 +971,7 @@ static void *map_sha1_file_1(struct repository *r, const char *path,
|
||||
if (!*size) {
|
||||
/* mmap() is forbidden on empty files */
|
||||
error(_("object file %s is empty"), path);
|
||||
close(fd);
|
||||
return NULL;
|
||||
}
|
||||
map = xmmap(NULL, *size, PROT_READ, MAP_PRIVATE, fd, 0);
|
||||
|
Loading…
Reference in New Issue
Block a user