undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-send-email: Don't set author_not_sender from Cc: lines

Browse Source 
When an mbox-style patch contains a Cc: line in the header,
git-send-email will check the address against the sender specified
on the command line. If they don't match, sender_not_author will
be set to the address obtained from the Cc line.

When this happens, git-send-email inserts a From: line at the
beginning of the message body with the address obtained from the
Cc line in the header, and the sender might be accused of forging
patch authors.

This patch fixes this by only updating sender_not_author when
processing From: lines, not when processing Cc: lines.

Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Haavard Skinnemoen 2006-08-23 03:02:59 -07:00 committed by Junio C Hamano
parent 44c10841ea
commit 68d42c41ef
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
git-send-email.perl
View File

@ -510,7 +510,7 @@ foreach my $t (@files) {
if ($2 eq $from) { if ($2 eq $from) {
next if ($suppress_from); next if ($suppress_from);
} }
else { elsif ($1 eq 'From') {
$author_not_sender = $2; $author_not_sender = $2;
} }
printf("(mbox) Adding cc: %s from line '%s'\n", printf("(mbox) Adding cc: %s from line '%s'\n",