undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

for_each_reflog_ent_reverse: turn leftover check into assertion

Browse Source 
Our loop should always process all lines, even if we hit the
beginning of the file. We have a conditional after the loop
ends to double-check that there is nothing left and to
process it. But this should never happen, and is a sign of a
logic bug in the loop. Let's turn it into a BUG assertion.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2014-12-04 20:32:44 -05:00 committed by Junio C Hamano
parent e5e73ff20b
commit 69216bf72b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
refs.c
View File

@ -3136,7 +3136,7 @@ int for_each_reflog_ent_reverse(const char *refname, each_reflog_ent_fn fn, void
} }
if (!ret && sb.len) if (!ret && sb.len)
ret = show_one_reflog_ent(&sb, fn, cb_data); die("BUG: reverse reflog parser had leftover data");
fclose(logfp); fclose(logfp);
strbuf_release(&sb); strbuf_release(&sb);