undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vcs-svn: suppress signed/unsigned comparison warnings

Browse Source 
These are already safe because both sides of the comparison are
nonnegative.

This would normally not be important because Git is not -Wsign-compare
clean anyway, but we like to keep the vcs-svn/ lib to a higher
standard for convenience using it in other projects.

Signed-off-by: David Barr <davidbarr@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
This commit is contained in:
David Barr 2012-06-01 00:41:29 +10:00 committed by Jonathan Nieder
parent 53153e8382
commit 6a0b4438af
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
vcs-svn/fast_export.c
View File

@ -254,7 +254,7 @@ static int parse_ls_response(const char *response, uint32_t *mode,
} }
/* Mode. */ /* Mode. */
if (response_end - response < strlen("100644") || if (response_end - response < (signed) strlen("100644") ||
response[strlen("100644")] != ' ') response[strlen("100644")] != ' ')
die("invalid ls response: missing mode: %s", response); die("invalid ls response: missing mode: %s", response);
*mode = 0; *mode = 0;
@ -267,7 +267,7 @@ static int parse_ls_response(const char *response, uint32_t *mode,
} }
/* ' blob ' or ' tree ' */ /* ' blob ' or ' tree ' */
if (response_end - response < strlen(" blob ") || if (response_end - response < (signed) strlen(" blob ") ||
(response[1] != 'b' && response[1] != 't')) (response[1] != 'b' && response[1] != 't'))
die("unexpected ls response: not a tree or blob: %s", response); die("unexpected ls response: not a tree or blob: %s", response);
response += strlen(" blob "); response += strlen(" blob ");