undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

open_istream: remove unneeded check for null pointer

Browse Source 
'st' is allocated via xmalloc a few lines before and passed to
the stream opening functions.
The xmalloc function is written in a way that either 'st' is allocated
valid memory or xmalloc already dies.
The function calls to open_istream_* do not change 'st', as the pointer is
passed by reference and not a pointer of a pointer.

Hence 'st' cannot be null at that part of the code.

Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Stefan Beller 2013-07-23 15:16:04 +02:00 committed by Junio C Hamano
parent 9ae54a1dde
commit 6a907786af
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
streaming.c
View File

@ -149,7 +149,7 @@ struct git_istream *open_istream(const unsigned char *sha1,
return NULL; return NULL;
} }
} }
if (st && filter) { if (filter) {
/* Add "&& !is_null_stream_filter(filter)" for performance */ /* Add "&& !is_null_stream_filter(filter)" for performance */
struct git_istream *nst = attach_stream_filter(st, filter); struct git_istream *nst = attach_stream_filter(st, filter);
if (!nst) if (!nst)