undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-remote-mediawiki: rewrite unclear line of instructions

Browse Source 
Subroutines' parameters should be assigned to variable before doing anything
else
Besides, existing instruction affected a variable inside a "if", which break
Git's coding style

Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr>
Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Célestin Matte 2013-06-14 15:50:15 +02:00 committed by Junio C Hamano
parent 81f6a7a43d
commit 6c2fbe25fb
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
contrib/mw-to-git/git-remote-mediawiki.perl
View File

@ -1333,7 +1333,8 @@ sub get_mw_namespace_id {
} }
sub get_mw_namespace_id_for_page { sub get_mw_namespace_id_for_page {
if (my ($namespace) = $_[0] =~ /^([^:]*):/) { my $namespace = shift;
if ($namespace =~ /^([^:]*):/) {
return get_mw_namespace_id($namespace); return get_mw_namespace_id($namespace);
} else { } else {
return; return;