undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

merge-ort: make a separate function for freeing struct collisions

Browse Source 
This commit makes no functional changes, it's just some code movement in
preparation for later changes.

Signed-off-by: Elijah Newren <newren@palantir.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Elijah Newren 2022-07-05 01:33:41 +00:00 committed by Junio C Hamano
parent 51e41e4eaf
commit 6dd1f0e9d4
1 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
merge-ort.c
View File

@ -2259,6 +2259,27 @@ static void compute_collisions(struct strmap *collisions,
} }
} }
static void free_collisions(struct strmap *collisions)
{
struct hashmap_iter iter;
struct strmap_entry *entry;
/* Free each value in the collisions map */
strmap_for_each_entry(collisions, &iter, entry) {
struct collision_info *info = entry->value;
string_list_clear(&info->source_files, 0);
}
/*
* In compute_collisions(), we set collisions.strdup_strings to 0
* so that we wouldn't have to make another copy of the new_path
* allocated by apply_dir_rename(). But now that we've used them
* and have no other references to these strings, it is time to
* deallocate them.
*/
free_strmap_strings(collisions);
strmap_clear(collisions, 1);
}
static char *check_for_directory_rename(struct merge_options *opt, static char *check_for_directory_rename(struct merge_options *opt,
const char *path, const char *path,
unsigned side_index, unsigned side_index,
@ -3029,8 +3050,6 @@ static int collect_renames(struct merge_options *opt,
int i, clean = 1; int i, clean = 1;
struct strmap collisions; struct strmap collisions;
struct diff_queue_struct *side_pairs; struct diff_queue_struct *side_pairs;
struct hashmap_iter iter;
struct strmap_entry *entry;
struct rename_info *renames = &opt->priv->renames; struct rename_info *renames = &opt->priv->renames;
side_pairs = &renames->pairs[side_index]; side_pairs = &renames->pairs[side_index];
@ -3076,20 +3095,7 @@ static int collect_renames(struct merge_options *opt,
result->queue[result->nr++] = p; result->queue[result->nr++] = p;
} }
/* Free each value in the collisions map */ free_collisions(&collisions);
strmap_for_each_entry(&collisions, &iter, entry) {
struct collision_info *info = entry->value;
string_list_clear(&info->source_files, 0);
}
/*
* In compute_collisions(), we set collisions.strdup_strings to 0
* so that we wouldn't have to make another copy of the new_path
* allocated by apply_dir_rename(). But now that we've used them
* and have no other references to these strings, it is time to
* deallocate them.
*/
free_strmap_strings(&collisions);
strmap_clear(&collisions, 1);
return clean; return clean;
} }