undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gitk: Fix bug introduced by previous commit

Browse Source 
When I added the "--" case to the code scanning the arguments, I missed
the fact that since the switch statement uses -regexp, the "--" case
will match any argument containing "--", e.g. "--all".  This fixes it
by taking out the -regexp (since we don't actually need regular
expression matching) and adjusting the match strings.

A side effect of this is that previously any argument starting with
"-d" would be taken to indicate date mode; now the argument has to be
exactly "-d" if you want date mode.

Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Paul Mackerras 2007-07-13 13:45:55 +10:00
parent cdaee5db16
commit 6ebedabf2d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gitk
View File

@ -7478,9 +7478,9 @@ set revtreeargs {}
set cmdline_files {} set cmdline_files {}
set i 0 set i 0
foreach arg $argv { foreach arg $argv {
switch -regexp -- $arg { switch -- $arg {
"^$" { } "" { }
"^-d" { set datemode 1 } "-d" { set datemode 1 }
"--" { "--" {
set cmdline_files [lrange $argv [expr {$i + 1}] end] set cmdline_files [lrange $argv [expr {$i + 1}] end]
break break