undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf/aggregate: fix checking ENV{GIT_PERF_SUBSECTION}

Browse Source 
The way we check ENV{GIT_PERF_SUBSECTION} could trigger
comparison between undef and "" that may be flagged by
use of strict & warnings. Let's fix that.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Christian Couder 2018-01-05 10:12:20 +01:00 committed by Junio C Hamano
parent 5d445f3416
commit 6f5ecad6a5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
t/perf/aggregate.perl
View File

@ -70,7 +70,7 @@ if (not @tests) {
}
my $resultsdir = "test-results";
if ($ENV{GIT_PERF_SUBSECTION} ne "") {
if (exists $ENV{GIT_PERF_SUBSECTION} and $ENV{GIT_PERF_SUBSECTION} ne "") {
$resultsdir .= "/" . $ENV{GIT_PERF_SUBSECTION};
}