undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

config_set_multivar(): disallow newlines in keys

Browse Source 
This will no longer work:

$ git repo-config 'key.with
newline' some-value

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
This commit is contained in:
Johannes Schindelin 2007-01-20 02:25:37 +01:00 committed by Junio C Hamano
parent d23842fd53
commit 6f71686e0b
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
config.c
View File

@ -661,6 +661,11 @@ int git_config_set_multivar(const char* key, const char* value,
goto out_free; goto out_free;
} }
c = tolower(c); c = tolower(c);
} else if (c == '\n') {
fprintf(stderr, "invalid key (newline): %s\n", key);
free(store.key);
ret = 1;
goto out_free;
} }
store.key[i] = c; store.key[i] = c;
} }

6
t/t1300-repo-config.sh
View File

@ -418,5 +418,11 @@ EOF
test_expect_success 'quoting' 'cmp .git/config expect' test_expect_success 'quoting' 'cmp .git/config expect'
test_expect_failure 'key with newline' 'git repo-config key.with\\\
newline 123'
test_expect_success 'value with newline' 'git repo-config key.sub value.with\\\
newline'
test_done test_done