undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gitk: Fix bug causing undefined variable error when cherry-picking

Browse Source 
When "Show nearby tags" is turned off and the user did a cherry-pick,
we were trying to access variables relating to the descendent/ancestor
tag & head computations in addnewchild though they hadn't been set.
This makes sure we don't do that.  Reported by Johannes Sixt.

Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Paul Mackerras 2007-08-29 22:41:34 +10:00
parent 887c996e46
commit 719c2b9d92
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gitk
View File

@ -6641,8 +6641,9 @@ proc splitarc {p} {
proc addnewchild {id p} { proc addnewchild {id p} {
global allids allparents allchildren idtags nextarc nbmp global allids allparents allchildren idtags nextarc nbmp
global arcnos arcids arctags arcout arcend arcstart archeads growing global arcnos arcids arctags arcout arcend arcstart archeads growing
global seeds global seeds allcommits
if {![info exists allcommits]} return
lappend allids $id lappend allids $id
set allparents($id) [list $p] set allparents($id) [list $p]
set allchildren($id) {} set allchildren($id) {}