undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

shortlog: do not crash on parsing "[PATCH"

Browse Source 
Annoyingly, it looked for the closing bracket in the author name
instead of in the message, and then accessed the NULL pointer.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Johannes Schindelin 2006-11-19 17:28:25 +01:00 committed by Junio C Hamano
parent b8ec59234b
commit 72019cdefe
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
builtin-shortlog.c
View File

@ -108,13 +108,15 @@ static void insert_author_oneline(struct path_list *list,
free(buffer); free(buffer);
if (!strncmp(oneline, "[PATCH", 6)) { if (!strncmp(oneline, "[PATCH", 6)) {
char *eob = strchr(buffer, ']'); char *eob = strchr(oneline, ']');
while (isspace(eob[1]) && eob[1] != '\n') if (eob) {
eob++; while (isspace(eob[1]) && eob[1] != '\n')
if (eob - oneline < onelinelen) { eob++;
onelinelen -= eob - oneline; if (eob - oneline < onelinelen) {
oneline = eob; onelinelen -= eob - oneline;
oneline = eob;
}
} }
} }