From 7334f06ce6c53e161d1c183a5f93a23992b3c440 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Sat, 4 Feb 2006 22:10:32 -0800 Subject: [PATCH] Do not fall back on vi on dumb terminals. When TERM is set to 'dumb', do not start vi to edit the commit log message. Suggested by Amos Waterland. Signed-off-by: Junio C Hamano --- git-commit.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/git-commit.sh b/git-commit.sh index 193feeb5e4..10946ed5f9 100755 --- a/git-commit.sh +++ b/git-commit.sh @@ -207,6 +207,14 @@ then fi case "$no_edit" in '') + case "${VISUAL:-$EDITOR},$TERM" in + ,dumb) + echo >&2 "Terminal is dumb but no VISUAL nor EDITOR defined." + echo >&2 "Please supply the commit log message using either" + echo >&2 "-m or -F option. A boilerplate log message has" + echo >&2 "been prepared in $GIT_DIR/COMMIT_EDITMSG" + exit 1 ;; + esac ${VISUAL:-${EDITOR:-vi}} "$GIT_DIR/COMMIT_EDITMSG" ;; esac