undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gitweb: Remove function prototypes (cleanup)

Browse Source 
Use of function prototypes is considered bad practice in Perl.  The
ones used here didn't accomplish anything anyhow, so they've been
removed.

>From perlsub(1):

  [...] the intent of this feature [prototypes] is primarily to let
  you define subroutines that work like built-in functions [...]
  you can generate new syntax with it [...]

We don't want to have subroutines behaving exactly like built-in
functions, we don't want to define new syntax / syntactic sugar, so
prototypes in gitweb are not needed... and they can have unintended
consequences.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jakub Narebski 2009-05-07 19:11:29 +02:00 committed by Junio C Hamano
parent 5a0e4a2a32
commit 74fd8728e2
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gitweb/gitweb.perl
View File

@ -838,7 +838,7 @@ exit;
## ======================================================================
## action links
sub href (%) {
sub href {
my %params = @_;
# default is to use -absolute url() i.e. $my_uri
my $href = $params{-full} ? $my_url : $my_uri;
@ -1036,7 +1036,7 @@ sub esc_url {
}
# replace invalid utf8 character with SUBSTITUTION sequence
sub esc_html ($;%) {
sub esc_html {
my $str = shift;
my %opts = @_;
@ -1296,7 +1296,7 @@ use constant {
};
# submodule/subproject, a commit object reference
sub S_ISGITLINK($) {
sub S_ISGITLINK {
my $mode = shift;
return (($mode & S_IFMT) == S_IFGITLINK)
@ -2615,7 +2615,7 @@ sub parsed_difftree_line {
}
# parse line of git-ls-tree output
sub parse_ls_tree_line ($;%) {
sub parse_ls_tree_line {
my $line = shift;
my %opts = @_;
my %res;
@ -3213,7 +3213,6 @@ sub git_print_header_div {
"\n</div>\n";
}
#sub git_print_authorship (\%) {
sub git_print_authorship {
my $co = shift;
@ -3269,8 +3268,7 @@ sub git_print_page_path {
print "<br/></div>\n";
}
# sub git_print_log (\@;%) {
sub git_print_log ($;%) {
sub git_print_log {
my $log = shift;
my %opts = @_;