undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests: drop here-doc check from internal chain-linter

Browse Source 
Commit 99a64e4b73 (tests: lint for run-away here-doc, 2017-03-22)
tweaked the chain-lint test to catch unclosed here-docs. It works by
adding an extra "echo" command after the test snippet, and checking that
it is run (if it gets swallowed by a here-doc, naturally it is not run).

The downside here is that we introduced an extra $() substitution, which
happens in a subshell. This has a measurable performance impact when
run for many tests.

The tradeoff in safety was undoubtedly worth it when 99a64e4b73 was
written. But since the external chainlint.pl learned to find these
recently, we can just rely on it. By switching back to a simpler
chain-lint, hyperfine reports a measurable speedup on t3070 (which has
1800 tests):

  'HEAD' ran
    1.12 ± 0.01 times faster than 'HEAD~1'

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2023-03-30 15:30:47 -04:00 committed by Junio C Hamano
parent 2b61c8dc88
commit 750b260411
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
t/test-lib.sh
View File

@ -1101,9 +1101,10 @@ test_run_ () {
trace= trace=
# 117 is magic because it is unlikely to match the exit # 117 is magic because it is unlikely to match the exit
# code of other programs # code of other programs
if test "OK-117" != "$(test_eval_ "fail_117 && $1${LF}${LF}echo OK-\$?" 3>&1)" test_eval_ "fail_117 && $1"
if test $? != 117
then then
BUG "broken &&-chain or run-away HERE-DOC: $1" BUG "broken &&-chain: $1"
fi fi
trace=$trace_tmp trace=$trace_tmp
fi fi