undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not misidentify "git merge foo HEAD" as an old-style invocation

Browse Source 
This was misinterpreted as an ancient style "git merge <message> HEAD
<commit> <commit>..." that merges one (or more) <commit> into the current
branch and record the resulting commit with the given message.  Then a
later sanity check found that there is no <commit> specified and gave
a usage message.

Tested-by: Nanako Shiraishi <nanako3@lavabit.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2009-12-02 09:59:35 -08:00
parent af6fbf9f81
commit 76bf488e61
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
builtin-merge.c
View File

@ -792,7 +792,7 @@ static int suggest_conflicts(void)
static struct commit *is_old_style_invocation(int argc, const char **argv) static struct commit *is_old_style_invocation(int argc, const char **argv)
{ {
struct commit *second_token = NULL; struct commit *second_token = NULL;
if (argc > 1) { if (argc > 2) {
unsigned char second_sha1[20]; unsigned char second_sha1[20];
if (get_sha1(argv[1], second_sha1)) if (get_sha1(argv[1], second_sha1))