Don't coredump on bad refs in update-server-info.
Apparently if we are unable to parse an object update-server-info coredumps, as it doesn't bother to check the return value of its call to parse_object. Instead of coredumping, skip the ref. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
parent
d117452a80
commit
76f8a302c7
@ -10,6 +10,8 @@ static FILE *info_ref_fp;
|
|||||||
static int add_info_ref(const char *path, const unsigned char *sha1, int flag, void *cb_data)
|
static int add_info_ref(const char *path, const unsigned char *sha1, int flag, void *cb_data)
|
||||||
{
|
{
|
||||||
struct object *o = parse_object(sha1);
|
struct object *o = parse_object(sha1);
|
||||||
|
if (!o)
|
||||||
|
return -1;
|
||||||
|
|
||||||
fprintf(info_ref_fp, "%s %s\n", sha1_to_hex(sha1), path);
|
fprintf(info_ref_fp, "%s %s\n", sha1_to_hex(sha1), path);
|
||||||
if (o->type == OBJ_TAG) {
|
if (o->type == OBJ_TAG) {
|
||||||
|
Loading…
Reference in New Issue
Block a user