undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t4216: avoid unnecessary subshell in test_bloom_filters_not_used

Browse Source 
Seems to trigger a bug in at least OpenBSD's 6.7 sh where it is
interpreted as a history lookup and therefore fails 125-126, 128,
130.

Remove the subshell and get a space between ! and grep, so tests
pass successfully.

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Carlo Marcelo Arenas Belón 2020-05-19 20:44:42 -07:00 committed by Junio C Hamano
parent caf388caa1
commit 784ce03d55
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
t/t4216-log-bloom.sh
View File

@ -70,7 +70,7 @@ test_bloom_filters_used () {
test_bloom_filters_not_used () { test_bloom_filters_not_used () {
log_args=$1 log_args=$1
setup "$log_args" && setup "$log_args" &&
!(grep -q "statistics:{\"filter_not_present\":" "$TRASH_DIRECTORY/trace.perf") && ! grep -q "statistics:{\"filter_not_present\":" "$TRASH_DIRECTORY/trace.perf" &&
test_cmp log_wo_bloom log_w_bloom test_cmp log_wo_bloom log_w_bloom
} }