undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-daemon poll() spinning out of control

Browse Source 
With the '0' timeout given to poll, it returns instantly without any
events on my system, causing git-daemon to consume all the CPU time. Use
-1 as the timeout so poll() only returns in case of EINTR or actually
events being available.

Signed-off-by: Jens Axboe <axboe@suse.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Jens Axboe 2005-10-20 00:52:32 -07:00 committed by Junio C Hamano
parent bfadbeddd1
commit 7872e05567
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
daemon.c
View File

@ -533,7 +533,7 @@ static int service_loop(int socknum, int *socklist)
for (;;) { for (;;) {
int i; int i;
if (poll(pfd, socknum, 0) < 0) { if (poll(pfd, socknum, -1) < 0) {
if (errno != EINTR) { if (errno != EINTR) {
error("poll failed, resuming: %s", error("poll failed, resuming: %s",
strerror(errno)); strerror(errno));