undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gitweb: bugfix: a.list formatting regression

Browse Source 
Fix regression introduced by
commit 17d0744318.

"a.list" being "bold", makes a myriad of things shown by
gitweb in bold font-weight, which is a regression from
pre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior.

The fix is to add "subject" class and use this class
to replace pre-format_subject_html formatting of subject
(comment) via using (or not) <b>...</b> element. This
should go back to the pre-17d0744318... style.

Regression noticed by Luben Tuikov.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Jakub Narebski 2006-08-22 12:02:48 +02:00 committed by Junio C Hamano
parent e8e41a9383
commit 7c27801473
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gitweb/gitweb.css
View File

@ -117,11 +117,14 @@ div.list_head {
a.list {
text-decoration: none;
font-weight: bold;
color: #000000;
}
table.tags a.list {
a.subject {
font-weight: bold;
}
table.tags a.subject {
font-weight: normal;
}

4
gitweb/gitweb.perl
View File

@ -504,11 +504,11 @@ sub format_subject_html {
$extra = '' unless defined($extra);
if (length($short) < length($long)) {
return $cgi->a({-href => $href, -class => "list",
return $cgi->a({-href => $href, -class => "list subject",
-title => $long},
esc_html($short) . $extra);
} else {
return $cgi->a({-href => $href, -class => "list"},
return $cgi->a({-href => $href, -class => "list subject"},
esc_html($long) . $extra);
}
}