undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not use h_errno after connect(2): the function does not set it

Browse Source 
Randal L. Schwartz noticed compilation problems on SunOS, which made
me look at the code again. The thing is, h_errno is not used by
connect(2), it is only for functions from netdb.h, like gethostbyname.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Alex Riesen 2007-06-12 22:52:10 +02:00 committed by Junio C Hamano
parent 3e48af3875
commit 7cbf2f24ee
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
connect.c
View File

@ -224,11 +224,10 @@ static int git_tcp_connect_sock(char *host, int flags)
} }
if (connect(sockfd, ai->ai_addr, ai->ai_addrlen) < 0) { if (connect(sockfd, ai->ai_addr, ai->ai_addrlen) < 0) {
saved_errno = errno; saved_errno = errno;
fprintf(stderr, "%s[%d: %s]: net=%s, errno=%s\n", fprintf(stderr, "%s[%d: %s]: errno=%s\n",
host, host,
cnt, cnt,
ai_name(ai), ai_name(ai),
hstrerror(h_errno),
strerror(saved_errno)); strerror(saved_errno));
close(sockfd); close(sockfd);
sockfd = -1; sockfd = -1;
@ -315,11 +314,10 @@ static int git_tcp_connect_sock(char *host, int flags)
if (connect(sockfd, (struct sockaddr *)&sa, sizeof sa) < 0) { if (connect(sockfd, (struct sockaddr *)&sa, sizeof sa) < 0) {
saved_errno = errno; saved_errno = errno;
fprintf(stderr, "%s[%d: %s]: net=%s, errno=%s\n", fprintf(stderr, "%s[%d: %s]: errno=%s\n",
host, host,
cnt, cnt,
inet_ntoa(*(struct in_addr *)&sa.sin_addr), inet_ntoa(*(struct in_addr *)&sa.sin_addr),
hstrerror(h_errno),
strerror(saved_errno)); strerror(saved_errno));
close(sockfd); close(sockfd);
sockfd = -1; sockfd = -1;