undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-completion.bash: consolidate cases in _git_stash()

Browse Source 
The $subcommand case statement in _git_stash() is quite repetitive.
Consolidate the cases together into one catch-all case to reduce the
repetition.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Denton Liu 2021-04-22 03:00:52 -07:00 committed by Junio C Hamano
parent 59d85a2a05
commit 7cdb096903
1 changed files with 2 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
contrib/completion/git-completion.bash
View File

@ -3032,21 +3032,6 @@ _git_stash ()
fi
case "$subcommand,$cur" in
push,--*)
__gitcomp_builtin stash_push
;;
save,--*)
__gitcomp_builtin stash_save
;;
pop,--*)
__gitcomp_builtin stash_pop
;;
apply,--*)
__gitcomp_builtin stash_apply
;;
drop,--*)
__gitcomp_builtin stash_drop
;;
list,--*)
# NEEDSWORK: can we somehow unify this with the options in _git_log() and _git_show()
__gitcomp_builtin stash_list "$__git_log_common_options $__git_diff_common_options"
@ -3054,8 +3039,8 @@ _git_stash ()
show,--*)
__gitcomp_builtin stash_show "$__git_diff_common_options"
;;
branch,--*)
__gitcomp_builtin stash_branch
*,--*)
__gitcomp_builtin "stash_$subcommand"
;;
branch,*)
if [ $cword -eq $((__git_cmd_idx+2)) ]; then
@ -3069,8 +3054,6 @@ _git_stash ()
__gitcomp_nl "$(__git stash list \
| sed -n -e 's/:.*//p')"
;;
*)
;;
esac
}