undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cvsexportcommit: do not run git programs in dashed form

Browse Source 
This ancient script runs "git-foo" all over the place, which is
OK for a scripted Porcelain in the Git suite, but asking "git" to
dispatch to subcommands is the usual way these days.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2020-08-26 12:46:50 -07:00
parent 675df192c5
commit 7cff3b67ac
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
git-cvsexportcommit.perl
View File

@ -30,7 +30,7 @@ if ($opt_w || $opt_W) {
# Remember where GIT_DIR is before changing to CVS checkout # Remember where GIT_DIR is before changing to CVS checkout
unless ($ENV{GIT_DIR}) { unless ($ENV{GIT_DIR}) {
# No GIT_DIR set. Figure it out for ourselves # No GIT_DIR set. Figure it out for ourselves
my $gd =`git-rev-parse --git-dir`; my $gd =`git rev-parse --git-dir`;
chomp($gd); chomp($gd);
$ENV{GIT_DIR} = $gd; $ENV{GIT_DIR} = $gd;
} }
@ -66,7 +66,7 @@ if ($opt_d) {
# resolve target commit # resolve target commit
my $commit; my $commit;
$commit = pop @ARGV; $commit = pop @ARGV;
$commit = safe_pipe_capture('git-rev-parse', '--verify', "$commit^0"); $commit = safe_pipe_capture('git', 'rev-parse', '--verify', "$commit^0");
chomp $commit; chomp $commit;
if ($?) { if ($?) {
die "The commit reference $commit did not resolve!"; die "The commit reference $commit did not resolve!";
@ -76,7 +76,7 @@ if ($?) {
my $parent; my $parent;
if (@ARGV) { if (@ARGV) {
$parent = pop @ARGV; $parent = pop @ARGV;
$parent = safe_pipe_capture('git-rev-parse', '--verify', "$parent^0"); $parent = safe_pipe_capture('git', 'rev-parse', '--verify', "$parent^0");
chomp $parent; chomp $parent;
if ($?) { if ($?) {
die "The parent reference did not resolve!"; die "The parent reference did not resolve!";
@ -84,7 +84,7 @@ if (@ARGV) {
} }
# find parents from the commit itself # find parents from the commit itself
my @commit = safe_pipe_capture('git-cat-file', 'commit', $commit); my @commit = safe_pipe_capture('git', 'cat-file', 'commit', $commit);
my @parents; my @parents;
my $committer; my $committer;
my $author; my $author;
@ -162,9 +162,9 @@ if ($opt_a) {
close MSG; close MSG;
if ($parent eq $noparent) { if ($parent eq $noparent) {
`git-diff-tree --binary -p --root $commit >.cvsexportcommit.diff`;# || die "Cannot diff"; `git diff-tree --binary -p --root $commit >.cvsexportcommit.diff`;# || die "Cannot diff";
} else { } else {
`git-diff-tree --binary -p $parent $commit >.cvsexportcommit.diff`;# || die "Cannot diff"; `git diff-tree --binary -p $parent $commit >.cvsexportcommit.diff`;# || die "Cannot diff";
} }
## apply non-binary changes ## apply non-binary changes
@ -178,7 +178,7 @@ my $context = $opt_p ? '' : '-C1';
print "Checking if patch will apply\n"; print "Checking if patch will apply\n";
my @stat; my @stat;
open APPLY, "GIT_INDEX_FILE=$tmpdir/index git-apply $context --summary --numstat<.cvsexportcommit.diff|" || die "cannot patch"; open APPLY, "GIT_INDEX_FILE=$tmpdir/index git apply $context --summary --numstat<.cvsexportcommit.diff|" || die "cannot patch";
@stat=<APPLY>; @stat=<APPLY>;
close APPLY || die "Cannot patch"; close APPLY || die "Cannot patch";
my (@bfiles,@files,@afiles,@dfiles); my (@bfiles,@files,@afiles,@dfiles);
@ -333,7 +333,7 @@ print "Applying\n";
if ($opt_W) { if ($opt_W) {
system("git checkout -q $commit^0") && die "cannot patch"; system("git checkout -q $commit^0") && die "cannot patch";
} else { } else {
`GIT_INDEX_FILE=$tmpdir/index git-apply $context --summary --numstat --apply <.cvsexportcommit.diff` || die "cannot patch"; `GIT_INDEX_FILE=$tmpdir/index git apply $context --summary --numstat --apply <.cvsexportcommit.diff` || die "cannot patch";
} }
print "Patch applied successfully. Adding new files and directories to CVS\n"; print "Patch applied successfully. Adding new files and directories to CVS\n";