undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

short circuit out of a few places where we would allocate zero bytes

Browse Source 
dietlibc versions of malloc, calloc and realloc all return NULL if
they're told to allocate 0 bytes, causes the x* wrappers to die().

There are several more places where these calls could end up asking
for 0 bytes, too...

Maybe simply not die()-ing in the x* wrappers if 0/NULL is returned
when the requested size is zero is a safer and easier way to go.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Eric Wong 2005-12-24 04:12:43 -08:00 committed by Junio C Hamano
parent ac44f3e7c0
commit 7d6fb370bc
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
commit.c
View File

@ -560,6 +560,9 @@ void sort_in_topological_order(struct commit_list ** list)
next = next->next; next = next->next;
count++; count++;
} }
if (!count)
return;
/* allocate an array to help sort the list */ /* allocate an array to help sort the list */
nodes = xcalloc(count, sizeof(*nodes)); nodes = xcalloc(count, sizeof(*nodes));
/* link the list to the array */ /* link the list to the array */

2
diffcore-rename.c
View File

@ -282,7 +282,7 @@ void diffcore_rename(struct diff_options *options)
else if (detect_rename == DIFF_DETECT_COPY) else if (detect_rename == DIFF_DETECT_COPY)
register_rename_src(p->one, 1); register_rename_src(p->one, 1);
} }
if (rename_dst_nr == 0 || if (rename_dst_nr == 0 || rename_src_nr == 0 ||
(0 < rename_limit && rename_limit < rename_dst_nr)) (0 < rename_limit && rename_limit < rename_dst_nr))
goto cleanup; /* nothing to do */ goto cleanup; /* nothing to do */