undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Micro-optimize prepare_alt_odb

Browse Source 
Calling getenv() is not that expensive, but its also not free,
and its certainly not cheaper than testing to see if alt_odb_tail
is not null.

Because we are calling prepare_alt_odb() from within find_sha1_file
every time we cannot find an object file locally we want to skip out
of prepare_alt_odb() as early as possible once we have initialized
our alternate list.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Shawn O. Pearce 2007-05-26 01:24:40 -04:00 committed by Junio C Hamano
parent d079837eee
commit 7dc24aa5a6
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sha1_file.c
View File

@ -376,11 +376,12 @@ void prepare_alt_odb(void)
{ {
const char *alt; const char *alt;
if (alt_odb_tail)
return;
alt = getenv(ALTERNATE_DB_ENVIRONMENT); alt = getenv(ALTERNATE_DB_ENVIRONMENT);
if (!alt) alt = ""; if (!alt) alt = "";
if (alt_odb_tail)
return;
alt_odb_tail = &alt_odb_list; alt_odb_tail = &alt_odb_list;
link_alt_odb_entries(alt, alt + strlen(alt), ':', NULL, 0); link_alt_odb_entries(alt, alt + strlen(alt), ':', NULL, 0);