undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t5801 (remote-helpers): add test to fetch tags

Browse Source 
This used to work, but commit e198b3a740 broke it.

  e198b3a740 (fetch: replace string-list used as a look-up table with a hashmap)

Probably all remote helpers that use the import method are affected, but
we didn't catch the issue.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Felipe Contreras 2019-06-03 21:13:27 -05:00 committed by Junio C Hamano
parent 6e17fb3409
commit 8144f09ccd
2 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
git-remote-testgit.sh
View File

@ -12,9 +12,14 @@ url=$2
dir="$GIT_DIR/testgit/$alias" dir="$GIT_DIR/testgit/$alias"
refspec="refs/heads/*:refs/testgit/$alias/heads/*" h_refspec="refs/heads/*:refs/testgit/$alias/heads/*"
t_refspec="refs/tags/*:refs/testgit/$alias/tags/*"
test -n "$GIT_REMOTE_TESTGIT_NOREFSPEC" && refspec="" if test -n "$GIT_REMOTE_TESTGIT_NOREFSPEC"
then
h_refspec=""
t_refspec=""
fi
GIT_DIR="$url/.git" GIT_DIR="$url/.git"
export GIT_DIR export GIT_DIR
@ -37,7 +42,8 @@ do
capabilities) capabilities)
echo 'import' echo 'import'
echo 'export' echo 'export'
test -n "$refspec" && echo "refspec $refspec" test -n "$h_refspec" && echo "refspec $h_refspec"
test -n "$t_refspec" && echo "refspec $t_refspec"
if test -n "$gitmarks" if test -n "$gitmarks"
then then
echo "*import-marks $gitmarks" echo "*import-marks $gitmarks"
@ -49,7 +55,7 @@ do
echo echo
;; ;;
list) list)
git for-each-ref --format='? %(refname)' 'refs/heads/' git for-each-ref --format='? %(refname)' 'refs/heads/' 'refs/tags/'
head=$(git symbolic-ref HEAD) head=$(git symbolic-ref HEAD)
echo "@$head HEAD" echo "@$head HEAD"
echo echo
@ -78,7 +84,8 @@ do
echo "feature done" echo "feature done"
git fast-export \ git fast-export \
${refspec:+"--refspec=$refspec"} \ ${h_refspec:+"--refspec=$h_refspec"} \
${t_refspec:+"--refspec=$t_refspec"} \
${testgitmarks:+"--import-marks=$testgitmarks"} \ ${testgitmarks:+"--import-marks=$testgitmarks"} \
${testgitmarks:+"--export-marks=$testgitmarks"} \ ${testgitmarks:+"--export-marks=$testgitmarks"} \
$refs $refs

10
t/t5801-remote-helpers.sh
View File

@ -301,4 +301,14 @@ test_expect_success 'fetch url' '
compare_refs server HEAD local FETCH_HEAD compare_refs server HEAD local FETCH_HEAD
' '
test_expect_failure 'fetch tag' '
(cd server &&
git tag v1.0
) &&
(cd local &&
git fetch
) &&
compare_refs local v1.0 server v1.0
'
test_done test_done