undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t/lib-pager.sh: remove unnecessary '^' from 'expr' regular expression

Browse Source 
Regular expressions matched by 'expr' have an implicit '^' at the beginning
of them and so are anchored to the beginning of the string.  Using the '^'
character to mean "match at the beginning", is redundant and could produce
the wrong result if 'expr' implementations interpret the '^' as a literal
'^'.  Additionally, GNU expr 5.97 complains like this:

   expr: warning: unportable BRE: `^[a-z][a-z]*$': using `^' as the first character of the basic regular expression is not portable; it is being ignored

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Brandon Casey 2010-06-21 12:37:13 -05:00 committed by Junio C Hamano
parent 0af88c15e2
commit 832ac79edf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
t/lib-pager.sh
View File

@ -9,7 +9,7 @@ test_expect_success 'determine default pager' '
test -n "$less" test -n "$less"
' '
if expr "$less" : '^[a-z][a-z]*$' >/dev/null if expr "$less" : '[a-z][a-z]*$' >/dev/null
then then
test_set_prereq SIMPLEPAGER test_set_prereq SIMPLEPAGER
fi fi