From 852a15d748034eec87adbee73a72689c8936fb8b Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Fri, 13 Feb 2015 12:20:25 -0800 Subject: [PATCH] send-email: ask confirmation if given encoding name is very short Sometimes people respond "y" (or "yes") when asked this question: Which 8bit encoding should I declare [UTF-8]? We already have a mechanism to avoid accepting a mistyped e-mail address (we ask to confirm when the given address lacks "@" in it); reuse it to trigger the same confirmation when given a very short answer. As a typical charset name is probably at least 4 chars or longer (e.g. "UTF8" spelled without the dash, or "Big5"), this would prevent such a mistake. Signed-off-by: Junio C Hamano --- git-send-email.perl | 1 + 1 file changed, 1 insertion(+) diff --git a/git-send-email.perl b/git-send-email.perl index fdb0029b59..eb32371151 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -733,6 +733,7 @@ if (!defined $auto_8bit_encoding && scalar %broken_encoding) { print " $f\n"; } $auto_8bit_encoding = ask("Which 8bit encoding should I declare [UTF-8]? ", + valid_re => qr/.{4}/, confirm_only => 1, default => "UTF-8"); }