undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

parse_tag_buffer(): do not prefixcmp() out of range

Browse Source 
There is a check (size < 64) at the beginning of the function, but
that only covers object+type lines.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Nguyễn Thái Ngọc Duy 2011-02-14 20:02:51 +07:00 committed by Junio C Hamano
parent 24231e063f
commit 855942528e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tag.c
View File

@ -97,7 +97,9 @@ int parse_tag_buffer(struct tag *item, const void *data, unsigned long size)
item->tagged = NULL; item->tagged = NULL;
} }
if (prefixcmp(bufptr, "tag ")) if (bufptr + 4 < tail && !prefixcmp(bufptr, "tag "))
; /* good */
else
return -1; return -1;
bufptr += 4; bufptr += 4;
nl = memchr(bufptr, '\n', tail - bufptr); nl = memchr(bufptr, '\n', tail - bufptr);
@ -106,7 +108,7 @@ int parse_tag_buffer(struct tag *item, const void *data, unsigned long size)
item->tag = xmemdupz(bufptr, nl - bufptr); item->tag = xmemdupz(bufptr, nl - bufptr);
bufptr = nl + 1; bufptr = nl + 1;
if (!prefixcmp(bufptr, "tagger ")) if (bufptr + 7 < tail && !prefixcmp(bufptr, "tagger "))
item->date = parse_tag_date(bufptr, tail); item->date = parse_tag_date(bufptr, tail);
else else
item->date = 0; item->date = 0;