undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refs: rename parameters result -> sha1

Browse Source 
Try consistently to use the name "sha1" for parameters to which a SHA1
will be stored.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael Haggerty 2011-12-12 06:38:10 +01:00 committed by Junio C Hamano
parent dfefa935ae
commit 85be1fe34a
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
refs.c
View File

@ -402,7 +402,7 @@ static struct ref_array *get_loose_refs(const char *submodule)
* the packed-refs file for the submodule. * the packed-refs file for the submodule.
*/ */
static int resolve_gitlink_packed_ref(char *name, int pathlen, static int resolve_gitlink_packed_ref(char *name, int pathlen,
const char *refname, unsigned char *result) const char *refname, unsigned char *sha1)
{ {
int retval = -1; int retval = -1;
struct ref_entry *ref; struct ref_entry *ref;
@ -415,14 +415,14 @@ static int resolve_gitlink_packed_ref(char *name, int pathlen,
array = get_packed_refs(name); array = get_packed_refs(name);
ref = search_ref_array(array, refname); ref = search_ref_array(array, refname);
if (ref != NULL) { if (ref != NULL) {
memcpy(result, ref->sha1, 20); memcpy(sha1, ref->sha1, 20);
retval = 0; retval = 0;
} }
return retval; return retval;
} }
static int resolve_gitlink_ref_recursive(char *name, int pathlen, static int resolve_gitlink_ref_recursive(char *name, int pathlen,
const char *refname, unsigned char *result, const char *refname, unsigned char *sha1,
int recursion) int recursion)
{ {
int fd, len = strlen(refname); int fd, len = strlen(refname);
@ -433,7 +433,7 @@ static int resolve_gitlink_ref_recursive(char *name, int pathlen,
memcpy(name + pathlen, refname, len+1); memcpy(name + pathlen, refname, len+1);
fd = open(name, O_RDONLY); fd = open(name, O_RDONLY);
if (fd < 0) if (fd < 0)
return resolve_gitlink_packed_ref(name, pathlen, refname, result); return resolve_gitlink_packed_ref(name, pathlen, refname, sha1);
len = read(fd, buffer, sizeof(buffer)-1); len = read(fd, buffer, sizeof(buffer)-1);
close(fd); close(fd);
@ -444,7 +444,7 @@ static int resolve_gitlink_ref_recursive(char *name, int pathlen,
buffer[len] = 0; buffer[len] = 0;
/* Was it a detached head or an old-fashioned symlink? */ /* Was it a detached head or an old-fashioned symlink? */
if (!get_sha1_hex(buffer, result)) if (!get_sha1_hex(buffer, sha1))
return 0; return 0;
/* Symref? */ /* Symref? */
@ -454,10 +454,10 @@ static int resolve_gitlink_ref_recursive(char *name, int pathlen,
while (isspace(*p)) while (isspace(*p))
p++; p++;
return resolve_gitlink_ref_recursive(name, pathlen, p, result, recursion+1); return resolve_gitlink_ref_recursive(name, pathlen, p, sha1, recursion+1);
} }
int resolve_gitlink_ref(const char *path, const char *refname, unsigned char *result) int resolve_gitlink_ref(const char *path, const char *refname, unsigned char *sha1)
{ {
int len = strlen(path), retval; int len = strlen(path), retval;
char *gitdir; char *gitdir;
@ -481,7 +481,7 @@ int resolve_gitlink_ref(const char *path, const char *refname, unsigned char *re
} }
gitdir[len] = '/'; gitdir[len] = '/';
gitdir[++len] = '\0'; gitdir[++len] = '\0';
retval = resolve_gitlink_ref_recursive(gitdir, len, refname, result, 0); retval = resolve_gitlink_ref_recursive(gitdir, len, refname, sha1, 0);
free(gitdir); free(gitdir);
return retval; return retval;
} }
@ -647,13 +647,13 @@ static int do_one_ref(const char *base, each_ref_fn fn, int trim,
return fn(entry->name + trim, entry->sha1, entry->flag, cb_data); return fn(entry->name + trim, entry->sha1, entry->flag, cb_data);
} }
static int filter_refs(const char *refname, const unsigned char *sha, int flags, static int filter_refs(const char *refname, const unsigned char *sha1, int flags,
void *data) void *data)
{ {
struct ref_filter *filter = (struct ref_filter *)data; struct ref_filter *filter = (struct ref_filter *)data;
if (fnmatch(filter->pattern, refname, 0)) if (fnmatch(filter->pattern, refname, 0))
return 0; return 0;
return filter->fn(refname, sha, flags, filter->cb_data); return filter->fn(refname, sha1, flags, filter->cb_data);
} }
int peel_ref(const char *refname, unsigned char *sha1) int peel_ref(const char *refname, unsigned char *sha1)

2
refs.h
View File

@ -134,7 +134,7 @@ extern char *shorten_unambiguous_ref(const char *refname, int strict);
extern int rename_ref(const char *oldref, const char *newref, const char *logmsg); extern int rename_ref(const char *oldref, const char *newref, const char *logmsg);
/** resolve ref in nested "gitlink" repository */ /** resolve ref in nested "gitlink" repository */
extern int resolve_gitlink_ref(const char *name, const char *refname, unsigned char *result); extern int resolve_gitlink_ref(const char *name, const char *refname, unsigned char *sha1);
/** lock a ref and then write its file */ /** lock a ref and then write its file */
enum action_on_err { MSG_ON_ERR, DIE_ON_ERR, QUIET_ON_ERR }; enum action_on_err { MSG_ON_ERR, DIE_ON_ERR, QUIET_ON_ERR };