undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib-proto-disable: variable name fix

Browse Source 
The test_proto function assigns the positional parameters to named
variables, but then still refers to "$desc" as "$1". Using $desc is
more readable and less error-prone.

Signed-off-by: Brandon Williams <bmwill@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Brandon Williams 2016-12-14 14:39:50 -08:00 committed by Junio C Hamano
parent 3680f16f9d
commit 85e4205365
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
t/lib-proto-disable.sh
View File

@ -9,7 +9,7 @@ test_proto () {
proto=$2
url=$3
test_expect_success "clone $1 (enabled)" '
test_expect_success "clone $desc (enabled)" '
rm -rf tmp.git &&
(
GIT_ALLOW_PROTOCOL=$proto &&
@ -18,7 +18,7 @@ test_proto () {
)
'
test_expect_success "fetch $1 (enabled)" '
test_expect_success "fetch $desc (enabled)" '
(
cd tmp.git &&
GIT_ALLOW_PROTOCOL=$proto &&
@ -27,7 +27,7 @@ test_proto () {
)
'
test_expect_success "push $1 (enabled)" '
test_expect_success "push $desc (enabled)" '
(
cd tmp.git &&
GIT_ALLOW_PROTOCOL=$proto &&
@ -36,7 +36,7 @@ test_proto () {
)
'
test_expect_success "push $1 (disabled)" '
test_expect_success "push $desc (disabled)" '
(
cd tmp.git &&
GIT_ALLOW_PROTOCOL=none &&
@ -45,7 +45,7 @@ test_proto () {
)
'
test_expect_success "fetch $1 (disabled)" '
test_expect_success "fetch $desc (disabled)" '
(
cd tmp.git &&
GIT_ALLOW_PROTOCOL=none &&
@ -54,7 +54,7 @@ test_proto () {
)
'
test_expect_success "clone $1 (disabled)" '
test_expect_success "clone $desc (disabled)" '
rm -rf tmp.git &&
(
GIT_ALLOW_PROTOCOL=none &&