undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

protocol-caps.c: fix memory leak in send_info()

Browse Source 
Fix a memory leak in a2ba162cda (object-info: support for retrieving
object info, 2021-04-20) which appears to have been based on a
misunderstanding of how the pkt-line.c API works. There is no need to
strdup() input to packet_writer_write(), it's just a printf()-like
format function.

This fixes a potentially large memory leak, since the number of OID
lines the "object-info" call can be arbitrarily large (or a small one
if the request is small).

This makes t5701-git-serve.sh pass again under SANITIZE=leak, as it
did before a2ba162cda.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Acked-by: Bruno Albuquerque <bga@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason 2021-08-31 15:46:42 +02:00 committed by Junio C Hamano
parent d94f9b8e90
commit 88682b016d
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
protocol-caps.c
View File

@ -69,9 +69,10 @@ static void send_info(struct repository *r, struct packet_writer *writer,
} }
} }
packet_writer_write(writer, "%s", packet_writer_write(writer, "%s", send_buffer.buf);
strbuf_detach(&send_buffer, NULL)); strbuf_reset(&send_buffer);
} }
strbuf_release(&send_buffer);
} }
int cap_object_info(struct repository *r, struct strvec *keys, int cap_object_info(struct repository *r, struct strvec *keys,