From 2aa839614e9d4f8b84803fb4ce633d6a0981675f Mon Sep 17 00:00:00 2001 From: Fredrik Kuivinen Date: Tue, 16 May 2006 07:58:15 +0200 Subject: [PATCH 1/3] Update the documentation for git-merge-base Signed-off-by: Fredrik Kuivinen Signed-off-by: Junio C Hamano --- Documentation/git-merge-base.txt | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/Documentation/git-merge-base.txt b/Documentation/git-merge-base.txt index d1d56f194a..6099be2add 100644 --- a/Documentation/git-merge-base.txt +++ b/Documentation/git-merge-base.txt @@ -8,16 +8,26 @@ git-merge-base - Finds as good a common ancestor as possible for a merge SYNOPSIS -------- -'git-merge-base' +'git-merge-base' [--all] DESCRIPTION ----------- -"git-merge-base" finds as good a common ancestor as possible. Given a -selection of equally good common ancestors it should not be relied on -to decide in any particular way. + +"git-merge-base" finds as good a common ancestor as possible between +the two commits. That is, given two commits A and B 'git-merge-base A +B' will output a commit which is reachable from both A and B through +the parent relationship. + +Given a selection of equally good common ancestors it should not be +relied on to decide in any particular way. The "git-merge-base" algorithm is still in flux - use the source... +OPTIONS +------- +--all:: + Output all common ancestors for the two commits instead of + just one. Author ------ From c82a22c39cbc32576f64f5c6b3f24b99ea8149c7 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Tue, 16 May 2006 17:18:22 -0700 Subject: [PATCH 2/3] merge-base: Clarify the comments on post processing. The comment fooled myself believing that we still had an unsolved horizon effect. Signed-off-by: Junio C Hamano --- merge-base.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/merge-base.c b/merge-base.c index f0dc06ef55..4856ca01c3 100644 --- a/merge-base.c +++ b/merge-base.c @@ -82,8 +82,9 @@ static struct commit *interesting(struct commit_list *list) * commit B. * * - * Another pathological example how this thing can fail to mark an ancestor - * of a merge base as UNINTERESTING without the postprocessing phase. + * Another pathological example how this thing used to fail to mark an + * ancestor of a merge base as UNINTERESTING before we introduced the + * postprocessing phase (mark_reachable_commits). * * 2 * H @@ -118,7 +119,9 @@ static struct commit *interesting(struct commit_list *list) * D7 2 3 7 7 3 2 1 2 * E7 2 3 7 7 7 2 1 2 * - * and we end up showing E as an interesting merge base. + * and we ended up showing E as an interesting merge base. + * The postprocessing phase re-injects C and continues traversal + * to contaminate D and E. */ static int show_all = 0; From 63dffdf03da65ddf1a02c3215ad15ba109189d42 Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Tue, 16 May 2006 16:46:31 -0700 Subject: [PATCH 3/3] Remove old "git-grep.sh" remnants It's built-in now. Signed-off-by: Linus Torvalds Signed-off-by: Junio C Hamano --- Makefile | 5 +++-- git-grep.sh | 62 ----------------------------------------------------- 2 files changed, 3 insertions(+), 64 deletions(-) delete mode 100755 git-grep.sh diff --git a/Makefile b/Makefile index 93779b06f1..9ba608c805 100644 --- a/Makefile +++ b/Makefile @@ -124,7 +124,7 @@ SCRIPT_SH = \ git-tag.sh git-verify-tag.sh \ git-applymbox.sh git-applypatch.sh git-am.sh \ git-merge.sh git-merge-stupid.sh git-merge-octopus.sh \ - git-merge-resolve.sh git-merge-ours.sh git-grep.sh \ + git-merge-resolve.sh git-merge-ours.sh \ git-lost-found.sh SCRIPT_PERL = \ @@ -169,7 +169,8 @@ PROGRAMS = \ git-describe$X git-merge-tree$X git-blame$X git-imap-send$X BUILT_INS = git-log$X git-whatchanged$X git-show$X \ - git-count-objects$X git-diff$X git-push$X + git-count-objects$X git-diff$X git-push$X \ + git-grep$X # what 'all' will build and 'install' will install, in gitexecdir ALL_PROGRAMS = $(PROGRAMS) $(SIMPLE_PROGRAMS) $(SCRIPTS) diff --git a/git-grep.sh b/git-grep.sh deleted file mode 100755 index ad4f2fe810..0000000000 --- a/git-grep.sh +++ /dev/null @@ -1,62 +0,0 @@ -#!/bin/sh -# -# Copyright (c) Linus Torvalds, 2005 -# - -USAGE='[