undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fsck: treat a NUL in a tag header as an error

Browse Source 
We check the return value of verify_header() for commits already, so do
the same for tags as well.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Jeff King <peff@peff.net>
This commit is contained in:
René Scharfe 2015-11-19 17:25:31 +01:00 committed by Jeff King
parent 80c7f5a011
commit 8a272f291a
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fsck.c
View File

@ -711,7 +711,8 @@ static int fsck_tag_buffer(struct tag *tag, const char *data,
} }
} }
if (verify_headers(buffer, size, &tag->object, options)) ret = verify_headers(buffer, size, &tag->object, options);
if (ret)
goto done; goto done;
if (!skip_prefix(buffer, "object ", &buffer)) { if (!skip_prefix(buffer, "object ", &buffer)) {

2
t/t1450-fsck.sh
View File

@ -288,7 +288,7 @@ test_expect_success 'tag with bad tagger' '
grep "error in tag .*: invalid author/committer" out grep "error in tag .*: invalid author/committer" out
' '
test_expect_failure 'tag with NUL in header' ' test_expect_success 'tag with NUL in header' '
sha=$(git rev-parse HEAD) && sha=$(git rev-parse HEAD) &&
q_to_nul >tag-NUL-header <<-EOF && q_to_nul >tag-NUL-header <<-EOF &&
object $sha object $sha