undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

object-file: convert 'switch' back to 'if'

Browse Source 
This switch statement was recently added to make it clear that
unpack_loose_header() returns an enum value, not an int. This adds
complications for future developers if that enum gains new values, since
that developer would need to add a case statement to this switch for
little real value.

Instead, we can revert back to an 'if' statement, but make the enum
explicit by using "!= ULHR_OK" instead of assuming it has the numerical
value zero.

Co-authored-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Derrick Stolee <derrickstolee@github.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Derrick Stolee 2022-05-16 10:53:27 -04:00 committed by Junio C Hamano
parent 7c898554d7
commit 8a50571a0e
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
object-file.c
View File

@ -2623,12 +2623,8 @@ int read_loose_object(const char *path,
goto out; goto out;
} }
switch (unpack_loose_header(&stream, map, mapsize, hdr, sizeof(hdr), if (unpack_loose_header(&stream, map, mapsize, hdr, sizeof(hdr),
NULL)) { NULL) != ULHR_OK) {
case ULHR_OK:
break;
case ULHR_BAD:
case ULHR_TOO_LONG:
error(_("unable to unpack header of %s"), path); error(_("unable to unpack header of %s"), path);
goto out; goto out;
} }