undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clone: propagate object-format when cloning from void

Browse Source 
A user could prepare an empty repository and set it to use SHA256 as
the object format.  The new repository created by "git clone" from
such a repository however would not record that it is expecting
objects in the same SHA256 format.  This works as expected if the
source repository is not empty.

Just like we started copying the name of the primary branch from the
remote repository even if it is unborn in 3d8314f8 (clone: propagate
empty remote HEAD even with other branches, 2022-07-07), lift the
code that records the object format out of the block executed only
when cloning from an instantiated repository, so that it works also
when cloning from an empty repository.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2023-04-05 14:15:33 -07:00
parent ae73b2c8f1
commit 8b214c2e9d
2 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
builtin/clone.c
View File

@ -910,6 +910,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
int err = 0, complete_refs_before_fetch = 1; int err = 0, complete_refs_before_fetch = 1;
int submodule_progress; int submodule_progress;
int filter_submodules = 0; int filter_submodules = 0;
int hash_algo;
struct transport_ls_refs_options transport_ls_refs_options = struct transport_ls_refs_options transport_ls_refs_options =
TRANSPORT_LS_REFS_OPTIONS_INIT; TRANSPORT_LS_REFS_OPTIONS_INIT;
@ -1298,15 +1299,15 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
} }
} }
if (mapped_refs) {
int hash_algo = hash_algo_by_ptr(transport_get_hash_algo(transport));
/* /*
* Now that we know what algorithm the remote side is using, * Now that we know what algorithm the remote side is using,
* let's set ours to the same thing. * let's set ours to the same thing.
*/ */
initialize_repository_version(hash_algo, 1); hash_algo = hash_algo_by_ptr(transport_get_hash_algo(transport));
repo_set_hash_algo(the_repository, hash_algo); initialize_repository_version(hash_algo, 1);
repo_set_hash_algo(the_repository, hash_algo);
if (mapped_refs) {
/* /*
* transport_get_remote_refs() may return refs with null sha-1 * transport_get_remote_refs() may return refs with null sha-1
* in mapped_refs (see struct transport->get_refs_list * in mapped_refs (see struct transport->get_refs_list

11
t/t5702-protocol-v2.sh
View File

@ -269,6 +269,17 @@ test_expect_success 'clone propagates unborn HEAD from non-empty repo' '
grep "warning: remote HEAD refers to nonexistent ref" stderr grep "warning: remote HEAD refers to nonexistent ref" stderr
' '
test_expect_success 'clone propagates object-format from empty repo' '
test_when_finished "rm -fr src256 dst256" &&
echo sha256 >expect &&
git init --object-format=sha256 src256 &&
git clone src256 dst256 &&
git -C dst256 rev-parse --show-object-format >actual &&
test_cmp expect actual
'
test_expect_success 'bare clone propagates unborn HEAD from non-empty repo' ' test_expect_success 'bare clone propagates unborn HEAD from non-empty repo' '
test_when_finished "rm -rf file_unborn_parent file_unborn_child.git" && test_when_finished "rm -rf file_unborn_parent file_unborn_child.git" &&