From 8be707de55e473a5d850a1fcdc6e30589a37d548 Mon Sep 17 00:00:00 2001 From: Sergey Vlasov Date: Fri, 23 Sep 2005 16:28:23 +0400 Subject: [PATCH] [PATCH] git-local-fetch: Fix error checking and leak in setup_indices() setup_indices() did not check the return value of opendir(), and did not have a corresponding closedir() call. Signed-off-by: Sergey Vlasov Signed-off-by: Junio C Hamano --- local-fetch.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/local-fetch.c b/local-fetch.c index 8176532320..b3947a9657 100644 --- a/local-fetch.c +++ b/local-fetch.c @@ -38,6 +38,8 @@ static int setup_indices(void) unsigned char sha1[20]; sprintf(filename, "%s/objects/pack/", path); dir = opendir(filename); + if (!dir) + return -1; while ((de = readdir(dir)) != NULL) { int namelen = strlen(de->d_name); if (namelen != 50 || @@ -46,6 +48,7 @@ static int setup_indices(void) get_sha1_hex(de->d_name + 5, sha1); setup_index(sha1); } + closedir(dir); return 0; }