From 8bef62049b46038334ed6f065fdac27758070a5e Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Tue, 16 Jan 2007 22:10:54 +0100 Subject: [PATCH] Fix spurious compile error From time to time, I would get this error: [...] sed: -e expression #8, char 41: Unterminated `s' command make: *** [git-add--interactive] Error 1 Turns out that the function WriteMakefile() called in Makefile.PL outputs the message "Writing perl.mak for Git" to stdout! Thus, the output of "make -C perl -s --no-print-directory instlibdir" would be prefixed by that message whenever Makefile.PL was newer than perl.mak. This is fixed by redirecting stdout to stderr in Makefile.PL. Signed-off-by: Johannes E. Schindelin Signed-off-by: Junio C Hamano --- perl/Makefile.PL | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/perl/Makefile.PL b/perl/Makefile.PL index 41687757a7..9b117fd0d7 100644 --- a/perl/Makefile.PL +++ b/perl/Makefile.PL @@ -20,6 +20,10 @@ if ($@) { my %extra; $extra{DESTDIR} = $ENV{DESTDIR} if $ENV{DESTDIR}; +# redirect stdout, otherwise the message "Writing perl.mak for Git" +# disrupts the output for the target 'instlibdir' +open STDOUT, ">&STDERR"; + WriteMakefile( NAME => 'Git', VERSION_FROM => 'Git.pm',