undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t1450: robustify remove_object()

Browse Source 
This function can be simplified by using the `test_oid_to_path()`
helper, which incidentally also makes it more robust by not relying on
the exact file system layout of the loose object files.

While at it, do not define those functions in a test case, it buys us
nothing.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Schindelin 2021-02-10 18:01:29 +00:00 committed by Junio C Hamano
parent 773e25afc4
commit 8c891eed3a
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
t/t1450-fsck.sh
View File

@ -40,17 +40,13 @@ test_expect_success 'HEAD is part of refs, valid objects appear valid' '
# specific corruption you test afterwards, lest a later test trip over
# it.
test_expect_success 'setup: helpers for corruption tests' '
sha1_file() {
remainder=${1#??} &&
firsttwo=${1%$remainder} &&
echo ".git/objects/$firsttwo/$remainder"
} &&
sha1_file () {
git rev-parse --git-path objects/$(test_oid_to_path "$1")
}
remove_object() {
rm "$(sha1_file "$1")"
}
'
remove_object () {
rm "$(sha1_file "$1")"
}
test_expect_success 'object with bad sha1' '
sha=$(echo blob | git hash-object -w --stdin) &&