undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t0026-eol-config.sh: use the $( ... ) construct for command substitution

Browse Source 
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
   sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Elia Pinto 2014-04-28 05:57:28 -07:00 committed by Junio C Hamano
parent 0bf6414996
commit 8deeab4a24
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
t/t0026-eol-config.sh
View File

@ -20,8 +20,8 @@ test_expect_success setup '
git commit -m initial &&
one=`git rev-parse HEAD:one` &&
two=`git rev-parse HEAD:two` &&
one=$(git rev-parse HEAD:one) &&
two=$(git rev-parse HEAD:two) &&
echo happy.
'
@ -34,8 +34,8 @@ test_expect_success 'eol=lf puts LFs in normalized file' '
! has_cr one &&
! has_cr two &&
onediff=`git diff one` &&
twodiff=`git diff two` &&
onediff=$(git diff one) &&
twodiff=$(git diff two) &&
test -z "$onediff" -a -z "$twodiff"
'
@ -47,8 +47,8 @@ test_expect_success 'eol=crlf puts CRLFs in normalized file' '
has_cr one &&
! has_cr two &&
onediff=`git diff one` &&
twodiff=`git diff two` &&
onediff=$(git diff one) &&
twodiff=$(git diff two) &&
test -z "$onediff" -a -z "$twodiff"
'
@ -61,8 +61,8 @@ test_expect_success 'autocrlf=true overrides eol=lf' '
has_cr one &&
has_cr two &&
onediff=`git diff one` &&
twodiff=`git diff two` &&
onediff=$(git diff one) &&
twodiff=$(git diff two) &&
test -z "$onediff" -a -z "$twodiff"
'
@ -75,8 +75,8 @@ test_expect_success 'autocrlf=true overrides unset eol' '
has_cr one &&
has_cr two &&
onediff=`git diff one` &&
twodiff=`git diff two` &&
onediff=$(git diff one) &&
twodiff=$(git diff two) &&
test -z "$onediff" -a -z "$twodiff"
'