undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

verify-commit: add test for exit status on untrusted signature

Browse Source 
verify-tag exits successfully if the signature is good but the key is
untrusted.  verify-commit exits unsuccessfully.  This divergence in
behavior is unexpected and unwanted.  Since verify-tag existed earlier,
add a failing test to have verify-commit share verify-tag's behavior.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
brian m. carlson 2015-06-21 23:14:39 +00:00 committed by Junio C Hamano
parent a4cc18f293
commit 8e98e5f27a
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
t/t7510-signed-commit.sh
View File

@ -81,6 +81,13 @@ test_expect_success GPG 'verify and show signatures' '
) )
' '
test_expect_failure GPG 'verify-commit exits success on untrusted signature' '
git verify-commit eighth-signed-alt 2>actual &&
grep "Good signature from" actual &&
! grep "BAD signature from" actual &&
grep "not certified" actual
'
test_expect_success GPG 'show signed commit with signature' ' test_expect_success GPG 'show signed commit with signature' '
git show -s initial >commit && git show -s initial >commit &&
git show -s --show-signature initial >show && git show -s --show-signature initial >show &&