undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-remote-mediawiki: change the name of a variable

Browse Source 
Local variable $url has the same name as a global variable. Changing the name
of the local variable prevents future possible misunderstanding.

Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr>
Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Célestin Matte 2013-06-14 15:50:22 +02:00 committed by Junio C Hamano
parent 8a43b36ac2
commit 8f04f7ddd3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
contrib/mw-to-git/git-remote-mediawiki.perl
View File

@ -454,14 +454,14 @@ sub get_mw_mediafile_for_page_revision {
} }
sub download_mw_mediafile { sub download_mw_mediafile {
my $url = shift; my $download_url = shift;
my $response = $mediawiki->{ua}->get($url); my $response = $mediawiki->{ua}->get($download_url);
if ($response->code == 200) { if ($response->code == 200) {
return $response->decoded_content; return $response->decoded_content;
} else { } else {
print STDERR "Error downloading mediafile from :\n"; print STDERR "Error downloading mediafile from :\n";
print STDERR "URL: $url\n"; print STDERR "URL: $download_url\n";
print STDERR "Server response: " . $response->code . " " . $response->message . "\n"; print STDERR "Server response: " . $response->code . " " . $response->message . "\n";
exit 1; exit 1;
} }