undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pull: do not abuse 'break' inside a shell 'case'

Browse Source 
It is not C. The code would break under mksh when 'pull.ff' is set:

  $ git pull
  /usr/lib/git-core/git-pull[67]: break: can't break
  Already up-to-date.

Signed-off-by: Jacek Konieczny <jajcus@jajcus.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jacek Konieczny 2014-06-11 10:47:45 +02:00 committed by Junio C Hamano
parent bce14aa132
commit 8f92c7755e
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
git-pull.sh
View File

@ -58,11 +58,9 @@ pull_ff=$(git config pull.ff)
case "$pull_ff" in case "$pull_ff" in
false) false)
no_ff=--no-ff no_ff=--no-ff
break
;; ;;
only) only)
ff_only=--ff-only ff_only=--ff-only
break
;; ;;
esac esac