undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HOME must be set before calling git-init when creating test repositories

Browse Source 
Otherwise the created test repositories will be affected by users ~/.gitconfig.
For example, setting core.logAllrefupdates in users config will make all
calls to "git config --unset core.logAllrefupdates" fail which will break
the first test which uses the statement and expects it to succeed.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Alex Riesen 2011-03-26 19:46:34 +01:00 committed by Junio C Hamano
parent f1723ee6b3
commit 90cff968b3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
t/test-lib.sh
View File

@ -1004,14 +1004,14 @@ rm -fr "$test" || {
exit 1 exit 1
} }
HOME="$TRASH_DIRECTORY"
export HOME
test_create_repo "$test" test_create_repo "$test"
# Use -P to resolve symlinks in our working directory so that the cwd # Use -P to resolve symlinks in our working directory so that the cwd
# in subprocesses like git equals our $PWD (for pathname comparisons). # in subprocesses like git equals our $PWD (for pathname comparisons).
cd -P "$test" || exit 1 cd -P "$test" || exit 1
HOME=$(pwd)
export HOME
this_test=${0##*/} this_test=${0##*/}
this_test=${this_test%%-*} this_test=${this_test%%-*}
for skp in $GIT_SKIP_TESTS for skp in $GIT_SKIP_TESTS