undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

list-objects-filter-options: make parser void

Browse Source 
This function always returns 0, so make it return void instead.

Signed-off-by: Matthew DeVore <matvore@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Matthew DeVore 2019-06-27 15:54:14 -07:00 committed by Junio C Hamano
parent 5a133e8a7f
commit 90d21f9ebf
2 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
list-objects-filter-options.c
View File

@ -232,7 +232,7 @@ void list_objects_filter_die_if_populated(
die(_("multiple filter-specs cannot be combined")); die(_("multiple filter-specs cannot be combined"));
} }
int parse_list_objects_filter( void parse_list_objects_filter(
struct list_objects_filter_options *filter_options, struct list_objects_filter_options *filter_options,
const char *arg) const char *arg)
{ {
@ -262,7 +262,6 @@ int parse_list_objects_filter(
} }
if (parse_error) if (parse_error)
die("%s", errbuf.buf); die("%s", errbuf.buf);
return 0;
} }
int opt_parse_list_objects_filter(const struct option *opt, int opt_parse_list_objects_filter(const struct option *opt,
@ -270,12 +269,11 @@ int opt_parse_list_objects_filter(const struct option *opt,
{ {
struct list_objects_filter_options *filter_options = opt->value; struct list_objects_filter_options *filter_options = opt->value;
if (unset || !arg) { if (unset || !arg)
list_objects_filter_set_no_filter(filter_options); list_objects_filter_set_no_filter(filter_options);
return 0; else
} parse_list_objects_filter(filter_options, arg);
return 0;
return parse_list_objects_filter(filter_options, arg);
} }
const char *list_objects_filter_spec(struct list_objects_filter_options *filter) const char *list_objects_filter_spec(struct list_objects_filter_options *filter)

2
list-objects-filter-options.h
View File

@ -74,7 +74,7 @@ void list_objects_filter_die_if_populated(
* *
* Dies and prints a user-facing message if an error occurs. * Dies and prints a user-facing message if an error occurs.
*/ */
int parse_list_objects_filter( void parse_list_objects_filter(
struct list_objects_filter_options *filter_options, struct list_objects_filter_options *filter_options,
const char *arg); const char *arg);