undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-svn bug with blank commits and author file

Browse Source 
When trying to import from svn using an author file, git-svn bails out
if it encounters a blank author. The attached patch changes this
behavior and allow using the author file with blanks authors.

I came across this bug while importing from a cvs2svn repo where the
initial revision (1) has a blank author. This doesn't break the behavior
of bailing out when an unknown author is encountered.

Acked-by: Eric Wong <normalperson@yhbt.net>

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Thomas Guyot-Sionnest 2008-04-22 06:07:47 -04:00 committed by Junio C Hamano
parent 75b7dfbdc0
commit 9231f500c3
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
git-svn.perl
View File

@ -2363,8 +2363,7 @@ sub check_author {
my ($author) = @_; my ($author) = @_;
if (!defined $author || length $author == 0) { if (!defined $author || length $author == 0) {
$author = '(no author)'; $author = '(no author)';
} } elsif (defined $::_authors && ! defined $::users{$author}) {
if (defined $::_authors && ! defined $::users{$author}) {
die "Author: $author not defined in $::_authors file\n"; die "Author: $author not defined in $::_authors file\n";
} }
$author; $author;