undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

grep: fix exit status if external_grep() punts

Browse Source 
If external_grep() is called and punts, grep_cache() mistakenly reported a
hit, even if there were none.  The bug can be triggered by calling "git
grep --no-color" from a subdirectory.

Signed-off-by: Clemens Buchacher <drizzd@aon.at>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Clemens Buchacher 2009-09-07 10:48:01 +02:00 committed by Junio C Hamano
parent e276f018f2
commit 929e37d3df
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
builtin-grep.c
View File

@ -448,6 +448,7 @@ static int grep_cache(struct grep_opt *opt, const char **paths, int cached)
hit = external_grep(opt, paths, cached); hit = external_grep(opt, paths, cached);
if (hit >= 0) if (hit >= 0)
return hit; return hit;
hit = 0;
} }
#endif #endif