undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

range-diff: internally force diff.noprefix=true

Browse Source 
When parsing the diffs, `range-diff` expects to see the prefixes `a/`
and `b/` in the diff headers.

These prefixes can be forced off via the config setting
`diff.noprefix=true`. As `range-diff` is not prepared for that
situation, this will cause a segmentation fault.

Let's avoid that by passing the `--no-prefix` option to the `git log`
process that generates the diffs that `range-diff` wants to parse.
And of course expect the output to have no prefixes, then.

Reported-by: Michal Suchánek <msuchanek@suse.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Schindelin 2019-10-02 14:10:47 -07:00 committed by Junio C Hamano
parent 5fa0f5238b
commit 937b76ed49
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
range-diff.c
View File

@ -52,6 +52,7 @@ static int read_patches(const char *range, struct string_list *list)
argv_array_pushl(&cp.args, "log", "--no-color", "-p", "--no-merges", argv_array_pushl(&cp.args, "log", "--no-color", "-p", "--no-merges",
"--reverse", "--date-order", "--decorate=no", "--reverse", "--date-order", "--decorate=no",
"--no-prefix",
/* /*
* Choose indicators that are not used anywhere * Choose indicators that are not used anywhere
* else in diffs, but still look reasonable * else in diffs, but still look reasonable
@ -111,7 +112,7 @@ static int read_patches(const char *range, struct string_list *list)
if (!util->diff_offset) if (!util->diff_offset)
util->diff_offset = buf.len; util->diff_offset = buf.len;
line[len - 1] = '\n'; line[len - 1] = '\n';
len = parse_git_diff_header(&root, &linenr, 1, line, len = parse_git_diff_header(&root, &linenr, 0, line,
len, size, &patch); len, size, &patch);
if (len < 0) if (len < 0)
die(_("could not parse git header '%.*s'"), (int)len, line); die(_("could not parse git header '%.*s'"), (int)len, line);

4
t/t3206-range-diff.sh
View File

@ -354,4 +354,8 @@ test_expect_success 'format-patch --range-diff as commentary' '
grep "> 1: .* new message" 0001-* grep "> 1: .* new message" 0001-*
' '
test_expect_success 'range-diff overrides diff.noprefix internally' '
git -c diff.noprefix=true range-diff HEAD^...
'
test_done test_done